netdev - Re: [PATCH net v3] net: renesas: rswitch: Fix timestamp feature after all descriptors are used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 8 Jun 2023 15:51:55 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc: s.shtylyov@....ru, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, lanhao@...wei.com,
	netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	Phong Hoang <phong.hoang.wz@...esas.com>
Subject: Re: [PATCH net v3] net: renesas: rswitch: Fix timestamp feature
 after all descriptors are used

On Thu, Jun 08, 2023 at 10:57:27AM +0900, Yoshihiro Shimoda wrote:
> The timestamp descriptors were intended to act cyclically. Descriptors
> from index 0 through gq->ring_size - 1 contain actual information, and
> the last index (gq->ring_size) should have LINKFIX to indicate
> the first index 0 descriptor. However, the LINKFIX value is missing,
> causing the timestamp feature to stop after all descriptors are used.
> To resolve this issue, set the LINKFIX to the timestamp descritors.
> 
> Reported-by: Phong Hoang <phong.hoang.wz@...esas.com>
> Fixes: 33f5d733b589 ("net: renesas: rswitch: Improve TX timestamp accuracy")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> ---
>  Since I got this report locally, I didn't add Closes: tag.
> 
>  Changes from v2:
> https://lore.kernel.org/all/20230607070141.1795982-1-yoshihiro.shimoda.uh@renesas.com/
>  - Rebase the latest net.git / main branch.
>  - Fix typo in the commit description.
>  - Modify the implementation of setting the last LINKFIX setting from
>    rswitch_gwca_ts_queue_fill() to rswitch_gwca_ts_queue_alloc() because
>    the last LINKFIX setting is only needed at the initialization time.
> 
>  Changes from v1:
> https://lore.kernel.org/all/20230607064402.1795548-1-yoshihiro.shimoda.uh@renesas.com/
>  - Fix typo in the subject.
> 
>  drivers/net/ethernet/renesas/rswitch.c | 36 ++++++++++++++++----------
>  1 file changed, 22 insertions(+), 14 deletions(-)

Hi all,

Hao Lan has provided a Reviewed-by for v2 [1], which was perhaps intended
for v3 (this version). In any case, I think we good on this one.

Reviewed-by: Simon Horman <simon.horman@...igine.com>

[1] https://lore.kernel.org/all/08006a4c-0627-9779-2260-a7e10dda454e@huawei.com/