netdev - Re: [PATCH 1/1] batman-adv: Broken sync while rescheduling delayed work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 08 Jun 2023 18:57:44 +0200
From: Sven Eckelmann <sven@...fation.org>
To: Jakub Kicinski <kuba@...nel.org>,
 Simon Wunderlich <sw@...onwunderlich.de>, Paolo Abeni <pabeni@...hat.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
 b.a.t.m.a.n@...ts.open-mesh.org, Vladislav Efanov <VEfanov@...ras.ru>,
 stable@...nel.org
Subject:
 Re: [PATCH 1/1] batman-adv: Broken sync while rescheduling delayed work

On Thursday, 8 June 2023 11:27:31 CEST Paolo Abeni wrote:
[...]
> > We're still not preventing the timer / work from getting scheduled
> > and staying alive after the netdev has been freed, right?
> 
> I *think* this specific use case does not expose such problem, as the
> delayed work is (AFAICS) scheduled only at device creation time and by
> the work itself, it should never be re-scheduled after
> cancel_delayed_work_sync()

Correct.

* batadv_dat_start_timer is the only thing scheduling it
* batadv_dat_start_timer is called by:

  - batadv_dat_purge (the worker rearming itself)
  - batadv_dat_init (when the interface is created)

Kind regards,
	Sven
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)