netdev - Re: [PATCH 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230607213620.4087b0e2@kernel.org>
Date: Wed, 7 Jun 2023 21:36:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Raymond Hackley <raymondhackley@...tonmail.com>
Cc: linux-kernel@...r.kernel.org, Krzysztof Kozlowski
 <krzysztof.kozlowski@...aro.org>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Rob
 Herring <robh+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark
 Brown <broonie@...nel.org>, Michael Walle <michael@...le.cc>, Uwe
 Kleine-König <u.kleine-koenig@...gutronix.de>, Jeremy
 Kerr <jk@...econstruct.com.au>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply

On Tue, 06 Jun 2023 07:25:55 +0000 Raymond Hackley wrote:
> +			if (r != -EPROBE_DEFER)
> +				dev_err(dev,
> +					"Failed to get regulator pvdd: %d\n",
> +					r);
> +			return r;

dev_err_probe() ?

> +	r = devm_add_action_or_reset(dev, nxp_nci_i2c_poweroff, phy);
> +	if (r < 0) {
> +		nfc_err(dev, "Failed to install poweroff handler: %d\n",
> +			r);
> +		nxp_nci_i2c_poweroff(phy);

The _or_reset() stands for "we'll call the action for you if we can't
add it". Don't call poweroff again.
-- 
pw-bot: cr