netdev - Re: [PATCH 1/1] batman-adv: Broken sync while rescheduling delayed work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230607220126.26c6ee40@kernel.org>
Date: Wed, 7 Jun 2023 22:01:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Simon Wunderlich <sw@...onwunderlich.de>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
 b.a.t.m.a.n@...ts.open-mesh.org, Vladislav Efanov <VEfanov@...ras.ru>,
 stable@...nel.org, Sven Eckelmann <sven@...fation.org>
Subject: Re: [PATCH 1/1] batman-adv: Broken sync while rescheduling delayed
 work

On Wed,  7 Jun 2023 17:55:15 +0200 Simon Wunderlich wrote:
> The reason for these issues is the lack of synchronization. Delayed
> work (batadv_dat_purge) schedules new timer/work while the device
> is being deleted. As the result new timer/delayed work is set after
> cancel_delayed_work_sync() was called. So after the device is freed
> the timer list contains pointer to already freed memory.

I guess this is better than status quo but is the fix really complete?
We're still not preventing the timer / work from getting scheduled
and staying alive after the netdev has been freed, right?