netdev - Re: [RFC,PATCH net-next 1/3] net: ngbe: add Wake on Lan support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20AD5BE0-FAF6-4ED3-8A53-4550FCD87BFA@net-swift.com>
Date: Thu, 8 Jun 2023 15:27:50 +0800
From: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org,
 Jiawen Wu <jiawenwu@...stnetic.com>
Subject: Re: [RFC,PATCH net-next 1/3] net: ngbe: add Wake on Lan support



> 2023年6月5日 21:00，Andrew Lunn <andrew@...n.ch> 写道：
> 
> On Mon, Jun 05, 2023 at 05:52:50PM +0800, Mengyuan Lou wrote:
>> Implement ethtool_ops get_wol.
>> Implement Wake-on-LAN support.
>> 
>> Magic packets are checked by fw, for now just support
>> WAKE_MAGIC and do not supoort to set_wol.
> 
> So are you saying WOL cannot be disabled? A magic packet will always
> wake the system?
> 
>  Can the
> interrupt be masked to disable WoL?
When Firmware find a magic packet, it will set the GPIO. 
Firmware do not care the interrupt of WOL.

> Can you disable WoL by not calling device_set_wakeup_enable()?
> 
It is work by calling device_set_wakeup_enable() to disable WOL.


> Is this specific to ngbe? Does txgbe have different firmware and
> different WoL support?
> 
I do not have NICs（txgbe）which is support to WOL.
I will add it after I will have tested it.


>  Andrew
> 
>