netdev - Re: [PATCH RFC net-next 1/4] net: add helpers for EEE configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIMulJhSQWc7SFEv@corigine.com>
Date: Fri, 9 Jun 2023 15:52:20 +0200
From: Simon Horman <simon.horman@...igine.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Marcin Wojtas <mw@...ihalf.com>,
	netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH RFC net-next 1/4] net: add helpers for EEE configuration

On Fri, Jun 09, 2023 at 10:11:16AM +0100, Russell King (Oracle) wrote:
> Add helpers that phylib and phylink can use to manage EEE configuration
> and determine whether the MAC should be permitted to use LPI based on
> that configuration.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  include/net/eee.h | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 include/net/eee.h
> 
> diff --git a/include/net/eee.h b/include/net/eee.h
> new file mode 100644
> index 000000000000..d353b79ae79f
> --- /dev/null
> +++ b/include/net/eee.h
> @@ -0,0 +1,38 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef _EEE_H
> +#define _EEE_H
> +
> +#include <linux/types.h>
> +
> +struct eee_config {
> +	u32 tx_lpi_timer;
> +	bool tx_lpi_enabled;
> +	bool eee_enabled;
> +};
> +
> +static inline bool eeecfg_mac_can_tx_lpi(const struct eee_config *eeecfg)
> +{
> +	/* eee_enabled is the master on/off */
> +	if (!eeecfg->eee_enabled || !eeecfg->tx_lpi_enabled)
> +		return false;
> +
> +	return true;
> +}
> +
> +static inline void eeecfg_to_eee(const struct eee_config *eeecfg,
> +			  struct ethtool_eee *eee)

Hi Russell,

a minor nit from my side: the indentation of the line above is a bit off.

> +{
> +	eee->tx_lpi_timer = eeecfg->tx_lpi_timer;
> +	eee->tx_lpi_enabled = eeecfg->tx_lpi_enabled;
> +	eee->eee_enabled = eeecfg->eee_enabled;
> +}
> +
> +static inline void eee_to_eeecfg(const struct ethtool_eee *eee,
> +				 struct eee_config *eeecfg)
> +{
> +	eeecfg->tx_lpi_timer = eee->tx_lpi_timer;
> +	eeecfg->tx_lpi_enabled = eee->tx_lpi_enabled;
> +	eeecfg->eee_enabled = eee->eee_enabled;
> +}
> +
> +#endif
> -- 
> 2.30.2
> 
>