netdev - Re: [PATCH net-next 2/2] netpoll: allocate netdev tracker right away

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKTjxqmAfa+HY3MX42aGezqgMQNGhJmfgTyaH+C+41Ebw@mail.gmail.com>
Date: Fri, 9 Jun 2023 20:46:17 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	dsahern@...il.com
Subject: Re: [PATCH net-next 2/2] netpoll: allocate netdev tracker right away

On Fri, Jun 9, 2023 at 8:32 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Commit 5fa5ae605821 ("netpoll: add net device refcount tracker to struct netpoll")
> was part of one of the initial netdev tracker introduction patches.
> It added an explicit netdev_tracker_alloc() for netpoll, presumably
> because the flow of the function is somewhat odd.
> After most of the core networking stack was converted to use
> the tracking hold() variants, netpoll's call to old dev_hold()
> stands out a bit.
>
> np is allocated by the caller and ready to use, we can use
> netdev_hold() here, even tho np->ndev will only be set to
> ndev inside __netpoll_setup().
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.