netdev - Re: [PATCH net-next 4/8] mlxsw: spectrum_router: Use the available router pointer for netevent handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIN4J9J0KuPARJCA@corigine.com>
Date: Fri, 9 Jun 2023 21:06:15 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 4/8] mlxsw: spectrum_router: Use the available
 router pointer for netevent handling

On Fri, Jun 09, 2023 at 07:32:09PM +0200, Petr Machata wrote:
> This code handles NETEVENT_DELAY_PROBE_TIME_UPDATE, which is invoked every
> time the delay_probe_time changes. mlxsw router currently only maintains
> one timer, so the last delay_probe_time set wins.
> 
> Currently, mlxsw uses mlxsw_sp_port_lower_dev_hold() to find a reference to
> the router. This is no longer necessary. But as a side effect, this makes
> sure that only updates to "interesting netdevices" (ones that have a
> physical netdevice lower) are projected.
> 
> Retain that side effect by calling mlxsw_sp_port_dev_lower_find_rcu() and
> punting if there is none. Then just proceed using the router pointer that's
> already at hand in the helper.
> 
> Note that previously, the code took and put a reference of the netdevice.
> Because the mlxsw_sp pointer is now obtained from the notifier block, the
> port pointer (non-) NULL-ness is all that's relevant, and the reference
> does not need to be taken anymore.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Amit Cohen <amcohen@...dia.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>