netdev - Re: [PATCH net-next 5/8] mlxsw: spectrum_router: Reuse work neighbor initialization in work scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIN4UTcdTdGCcvVV@corigine.com>
Date: Fri, 9 Jun 2023 21:06:57 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 5/8] mlxsw: spectrum_router: Reuse work neighbor
 initialization in work scheduler

On Fri, Jun 09, 2023 at 07:32:10PM +0200, Petr Machata wrote:
> After the struct mlxsw_sp_netevent_work.n field initialization is moved
> here, the body of code that handles NETEVENT_NEIGH_UPDATE is almost
> identical to the one in the helper function. Therefore defer to the helper
> instead of inlining the equivalent.
> 
> Note that previously, the code took and put a reference of the netdevice.
> The new code defers to mlxsw_sp_dev_lower_is_port() to obviate the need for
> taking the reference.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Amit Cohen <amcohen@...dia.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>