netdev - Re: [PATCH net-next] nfc: store __be16 value in _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 9 Jun 2023 09:53:16 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Luca Ceresoli <luca.ceresoli@...tlin.com>, 
	Michael Walle <michael@...le.cc>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] nfc: store __be16 value in __be16 variable

On Thu, Jun 8, 2023 at 4:52 PM Simon Horman <horms@...nel.org> wrote:

> Use a __be16 variable to store the store the big endian value of header
>
[Kalesh]: Minor nit, looks like a typo as "store the" is repeating.

> in nxp_nci_i2c_fw_read().
>
> Flagged by sparse as:
>
>  .../i2c.c:113:22: warning: cast to restricted __be16
>
> No functional changes intended.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@...nel.org>
> ---
>  drivers/nfc/nxp-nci/i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c
> index baddaf242d18..dca25a0c2f33 100644
> --- a/drivers/nfc/nxp-nci/i2c.c
> +++ b/drivers/nfc/nxp-nci/i2c.c
> @@ -97,8 +97,8 @@ static int nxp_nci_i2c_fw_read(struct nxp_nci_i2c_phy
> *phy,
>                                struct sk_buff **skb)
>  {
>         struct i2c_client *client = phy->i2c_dev;
> -       u16 header;
>         size_t frame_len;
> +       __be16 header;
>         int r;
>
>         r = i2c_master_recv(client, (u8 *) &header, NXP_NCI_FW_HDR_LEN);
>
>
>

-- 
Regards,
Kalesh A P

Content of type "text/html" skipped

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)