netdev - Re: [PATCH net-next v3] tcp: enforce receive buffer memory limits by allowing the tcp window to shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJb9zug7u1B042GM3XJ2T_4M0mmfz6Rhy41QvvGoBMKPg@mail.gmail.com>
Date: Sat, 10 Jun 2023 03:37:31 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: Mike Freemon <mfreemon@...udflare.com>, netdev@...r.kernel.org, 
	kernel-team@...udflare.com
Subject: Re: [PATCH net-next v3] tcp: enforce receive buffer memory limits by
 allowing the tcp window to shrink

On Sat, Jun 10, 2023 at 2:42 AM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Fri,  9 Jun 2023 15:47:06 -0500
> Mike Freemon <mfreemon@...udflare.com> wrote:
>
> > +     {
> > +             .procname       = "tcp_shrink_window",
> > +             .data           = &init_net.ipv4.sysctl_tcp_shrink_window,
> > +             .maxlen         = sizeof(u8),
> > +             .mode           = 0644,
> > +             .proc_handler   = proc_dou8vec_minmax,
> > +             .extra1         = SYSCTL_ZERO,
> > +             .extra2         = SYSCTL_ONE,
> > +     },
>
> NAK on introducing another sysctl.

We respectfully disagree.

A sysctl makes a lot of sense to us, as it allows us to not break many
packetdrill tests.