netdev - Re: [RFC PATCH v8 00/10] Create common DPLL configuration API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230609162739.0d94a704@kernel.org>
Date: Fri, 9 Jun 2023 16:27:39 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
Cc: jiri@...nulli.us, vadfed@...a.com, jonathan.lemon@...il.com,
 pabeni@...hat.com, corbet@....net, davem@...emloft.net,
 edumazet@...gle.com, vadfed@...com, jesse.brandeburg@...el.com,
 anthony.l.nguyen@...el.com, saeedm@...dia.com, leon@...nel.org,
 richardcochran@...il.com, sj@...nel.org, javierm@...hat.com,
 ricardo.canuelo@...labora.com, mst@...hat.com, tzimmermann@...e.de,
 michal.michalik@...el.com, gregkh@...uxfoundation.org,
 jacek.lawrynowicz@...ux.intel.com, airlied@...hat.com, ogabbay@...nel.org,
 arnd@...db.de, nipun.gupta@....com, axboe@...nel.dk, linux@...y.sk,
 masahiroy@...nel.org, benjamin.tissoires@...hat.com,
 geert+renesas@...der.be, milena.olech@...el.com, kuniyu@...zon.com,
 liuhangbin@...il.com, hkallweit1@...il.com, andy.ren@...cruise.com,
 razor@...ckwall.org, idosch@...dia.com, lucien.xin@...il.com,
 nicolas.dichtel@...nd.com, phil@....cc, claudiajkang@...il.com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
 linux-rdma@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 poros@...hat.com, mschmidt@...hat.com, linux-clk@...r.kernel.org,
 vadim.fedorenko@...ux.dev
Subject: Re: [RFC PATCH v8 00/10] Create common DPLL configuration API

On Fri,  9 Jun 2023 14:18:43 +0200 Arkadiusz Kubalewski wrote:
> Implement common API for clock/DPLL configuration and status reporting.
> The API utilises netlink interface as transport for commands and event
> notifications. This API aim to extend current pin configuration and
> make it flexible and easy to cover special configurations.
> 
> Netlink interface is based on ynl spec, it allows use of in-kernel
> tools/net/ynl/cli.py application to control the interface with properly
> formated command and json attribute strings. Here are few command
> examples of how it works with `ice` driver on supported NIC:

Now I see why you sent the ynl-gen patch you sent :) It's the
combination of nest and multi-attr which doesn't populate the right
policy. Also the enums are not policed right by ynl-gen.

I pushed two fixes to my local tree:
https://github.com/kuba-moo/linux/commits/ynl-c
in case you need them. I'll submit them on Monday.

I also tried to run the user space C code gen (for generating C
API/lib as described in [1]). It seems to work just fine, FWIW, so
just LMK if C bindings would be useful, I can give more instructions.

[1] https://docs.kernel.org/next/userspace-api/netlink/intro-specs.html#ynl-lib