netdev - Re: [PATCH net-next] net: add check for current MAC address in dev_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230609234439.3f415cd0@kernel.org>
Date: Fri, 9 Jun 2023 23:44:39 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Piotr Gardocki <piotrx.gardocki@...el.com>
Cc: netdev@...r.kernel.org, przemyslaw.kitszel@...el.com,
 michal.swiatkowski@...ux.intel.com, pmenzel@...gen.mpg.de,
 maciej.fijalkowski@...el.com, anthony.l.nguyen@...el.com,
 simon.horman@...igine.com, aleksander.lobakin@...el.com
Subject: Re: [PATCH net-next] net: add check for current MAC address in
 dev_set_mac_address

On Fri,  9 Jun 2023 18:52:41 +0200 Piotr Gardocki wrote:
> +	if (ether_addr_equal(dev->dev_addr, sa->sa_data))
> +		return 0;

not every device is ethernet, you need to use dev->addr_len for
the comparison.
-- 
pw-bot: cr