netdev - Re: [PATCH net-next] netdevsim: add dummy macsec offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 12 Jun 2023 01:08:59 +0800
From: kernel test robot <lkp@...el.com>
To: Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Sabrina Dubroca <sd@...asysnail.net>,
	kuba@...nel.org
Subject: Re: [PATCH net-next] netdevsim: add dummy macsec offload

Hi Sabrina,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Sabrina-Dubroca/netdevsim-add-dummy-macsec-offload/20230611-234644
base:   net-next/main
patch link:    https://lore.kernel.org/r/0b87a0b7f9faf82de05c5689fbe8b8b4a83aa25d.1686494112.git.sd%40queasysnail.net
patch subject: [PATCH net-next] netdevsim: add dummy macsec offload
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20230612/202306120129.MSWI7cn1-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add net-next https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
        git fetch net-next main
        git checkout net-next/main
        b4 shazam https://lore.kernel.org/r/0b87a0b7f9faf82de05c5689fbe8b8b4a83aa25d.1686494112.git.sd@queasysnail.net
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=s390 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306120129.MSWI7cn1-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/netdevsim/macsec.c: In function 'nsim_macsec_add_txsa':
>> drivers/net/netdevsim/macsec.c:274:27: warning: variable 'secy' set but not used [-Wunused-but-set-variable]
     274 |         struct nsim_secy *secy;
         |                           ^~~~
   drivers/net/netdevsim/macsec.c: In function 'nsim_macsec_upd_txsa':
   drivers/net/netdevsim/macsec.c:294:27: warning: variable 'secy' set but not used [-Wunused-but-set-variable]
     294 |         struct nsim_secy *secy;
         |                           ^~~~
   drivers/net/netdevsim/macsec.c: In function 'nsim_macsec_del_txsa':
   drivers/net/netdevsim/macsec.c:314:27: warning: variable 'secy' set but not used [-Wunused-but-set-variable]
     314 |         struct nsim_secy *secy;
         |                           ^~~~


vim +/secy +274 drivers/net/netdevsim/macsec.c

   270	
   271	static int nsim_macsec_add_txsa(struct macsec_context *ctx)
   272	{
   273		struct netdevsim *ns = netdev_priv(ctx->netdev);
 > 274		struct nsim_secy *secy;
   275		int idx;
   276	
   277		idx = nsim_macsec_find_secy(ns, ctx->secy->sci);
   278		if (idx < 0) {
   279			netdev_err(ctx->netdev, "%s: sci %08llx not found in secy table\n",
   280				   __func__, be64_to_cpu(ctx->secy->sci));
   281			return -ENOENT;
   282		}
   283		secy = &ns->macsec.nsim_secy[idx];
   284	
   285		netdev_dbg(ctx->netdev, "%s: SECY with sci %08llx, AN %u\n",
   286			   __func__, be64_to_cpu(ctx->secy->sci), ctx->sa.assoc_num);
   287	
   288		return 0;
   289	}
   290	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki