[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230611175429.GH12152@unreal>
Date: Sun, 11 Jun 2023 20:54:29 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc: "Michael S. Tsirkin" <mst@...hat.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
netdev@...r.kernel.org, Phani Burra <phani.r.burra@...el.com>,
pavan.kumar.linga@...el.com, emil.s.tantilov@...el.com,
sridhar.samudrala@...el.com, shiraz.saleem@...el.com,
sindhu.devale@...el.com, willemb@...gle.com, decot@...gle.com,
andrew@...n.ch, simon.horman@...igine.com, shannon.nelson@....com,
stephen@...workplumber.org, Alan Brady <alan.brady@...el.com>,
Madhu Chittim <madhu.chittim@...el.com>,
Shailendra Bhatnagar <shailendra.bhatnagar@...el.com>,
Krishneil Singh <krishneil.k.singh@...el.com>
Subject: Re: [PATCH net-next 02/15] idpf: add module register and probe
functionality
On Wed, May 31, 2023 at 11:34:23AM -0700, Jesse Brandeburg wrote:
> On 5/30/2023 11:05 PM, Michael S. Tsirkin wrote:
> > On Tue, May 30, 2023 at 04:44:48PM -0700, Tony Nguyen wrote:
> >> From: Phani Burra <phani.r.burra@...el.com>
> ...
>
> >> diff --git a/drivers/net/ethernet/intel/idpf/idpf_main.c b/drivers/net/ethernet/intel/idpf/idpf_main.c
> >> new file mode 100644
> >> index 000000000000..e290f560ce14
> >> --- /dev/null
> >> +++ b/drivers/net/ethernet/intel/idpf/idpf_main.c
> >> @@ -0,0 +1,136 @@
> >> +// SPDX-License-Identifier: GPL-2.0-only
> >> +/* Copyright (C) 2023 Intel Corporation */
> >> +
> >> +#include "idpf.h"
> >> +#include "idpf_devids.h"
> >> +
> >> +#define DRV_SUMMARY "Infrastructure Data Path Function Linux Driver"
> >
> > Do you want to stick Intel(R) here as well?
>
> That would be ok with me, we'll discuss internally.
>
> > And did you say you wanted to add a version?
>
> In-kernel drivers use the kernel version for the MODULE_VERSION field.
>
> > The point being making it possible to distinguish
> > between this one and the one we'll hopefully have down
> > the road binding to the IDPF class/prog ifc.
> >
> >> +
> >> +MODULE_DESCRIPTION(DRV_SUMMARY);
> >> +MODULE_LICENSE("GPL");
> Just noticed that we appear to have missed the MODULE_AUTHOR("Intel
> Corporation")
I'm not a lawyer, but company can't be author. It holds copyright to the work.
Thanks
>
>
>
Powered by blists - more mailing lists