netdev - Re: [PATCH net 1/4] selftests/tc-testing: Fix Error: Specified qdisc kind is unknown.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E38D09CB-AAC9-41D3-975A-4D4DA1B7E783@mojatatu.com>
Date: Mon, 12 Jun 2023 10:22:10 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Vlad Buslov <vladbu@...dia.com>
Cc: pabeni@...hat.com, davem@...emloft.net, kuba@...nel.org, shuah@...nel.org,
 jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
 marcelo.leitner@...il.com, shaozhengchao@...wei.com
Subject: Re: [PATCH net 1/4] selftests/tc-testing: Fix Error: Specified qdisc kind is unknown.

> On Jun 12, 2023, at 04:57, Vlad Buslov <vladbu@...dia.com> wrote:
> 
> All TEQL tests assume that sch_teql module is loaded. Load module in tdc.sh
> before running qdisc tests.
> 
> Fixes following example error when running tests via tdc.sh for all TEQL
> tests:
> 
> # $ sudo ./tdc.py -d eth2 -e 84a0
> #  -- ns/SubPlugin.__init__
> # Test 84a0: Create TEQL with default setting
> # exit: 2
> # exit: 0
> # Error: Specified qdisc kind is unknown.
> #
> # -----> teardown stage *** Could not execute: "$TC qdisc del dev $DUMMY handle 1: root"
> #
> # -----> teardown stage *** Error message: "Error: Invalid handle.
> # "
> # returncode 2; expected [0]
> #
> # -----> teardown stage *** Aborting test run.
> #
> # <_io.BufferedReader name=3> *** stdout ***
> #
> # <_io.BufferedReader name=5> *** stderr ***
> # "-----> teardown stage" did not complete successfully
> # Exception <class '__main__.PluginMgrTestFail'> ('teardown', 'Error: Specified qdisc kind is unknown.\n', '"-----> teardown stage" did not complete successfully') (caught in test_runner, running test 2 84a0 Create TEQL with default setting stage teardown)
> # ---------------
> # traceback
> #   File "/images/src/linux/tools/testing/selftests/tc-testing/./tdc.py", line 495, in test_runner
> #     res = run_one_test(pm, args, index, tidx)
> #   File "/images/src/linux/tools/testing/selftests/tc-testing/./tdc.py", line 434, in run_one_test
> #     prepare_env(args, pm, 'teardown', '-----> teardown stage', tidx['teardown'], procout)
> #   File "/images/src/linux/tools/testing/selftests/tc-testing/./tdc.py", line 245, in prepare_env
> #     raise PluginMgrTestFail(
> # ---------------
> # accumulated output for this test:
> # Error: Specified qdisc kind is unknown.
> #
> # ---------------
> #
> # All test results:
> #
> # 1..1
> # ok 1 84a0 - Create TEQL with default setting # skipped - "-----> teardown stage" did not complete successfully
> 
> Fixes: cc62fbe114c9 ("selftests/tc-testing: add selftests for teql qdisc")
> Signed-off-by: Vlad Buslov <vladbu@...dia.com>

Reviewed-by: Victor Nogueira <victor@...atatu.com>