lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b89d8987-574e-42cf-aaac-9c3524bc0610@lunn.ch>
Date: Mon, 12 Jun 2023 17:37:22 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jianhui Zhao <zhaojh329@...il.com>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: Assign the c45 id to phy_id property when
 matched.

On Mon, Jun 12, 2023 at 10:33:20PM +0800, Jianhui Zhao wrote:
> If a phydevice use c45, its phy_id property is always 0 previously.
> This change make the phy_id property has a valid value assigned from
> c45 id.

It is more than a valid value. It is the ID which was used to match
the device to a driver.

But as Russell pointed out, it is only valid if a match is made. And
if a match is made, you know what driver is loaded via the symlink in
sysfs. The more interesting use case is no match is performed and you
want to figure out why. And for that, you need all the IDs, since any
can be used to match to a driver.

So, back to a directory of all the IDs

I also asked that you update the sysfs documentation. I've asked this
twice now, and you have not done it. A patch will not be accepted
without the sysfs API documentation.

     Andrew

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ