netdev - Re: [PATCH net v2 3/3] igb: fix nvm.ops.read() error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4469ad5-7bac-3c2f-24f9-b2acc882e6c6@intel.com>
Date: Mon, 12 Jun 2023 13:31:28 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>, "Fijalkowski,
 Maciej" <maciej.fijalkowski@...el.com>
CC: "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Pucha, HimasekharX Reddy"
	<himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net v2 3/3] igb: fix nvm.ops.read() error handling

On 6/12/2023 12:42 PM, Loktionov, Aleksandr wrote:

...

>>> -839,7 +841,7 @@ static int igb_set_eeprom(struct net_device *netdev,
>>>   	/* Update the checksum if nvm write succeeded */
>>>   	if (ret_val == 0)
>>>   		hw->nvm.ops.update(hw);
>>> -
>>> +out:
>>>   	igb_set_fw_version(adapter);
>>
>> why would you want to call the above in case of fail? just move out below
>> and stick only to kfree() and return error code.
> 
> You're right it's better to move out: one line below.
> @Nguyen, Anthony L can you make it?

I'll update and re-send.

Thanks,
Tony

>>>   	kfree(eeprom_buff);
>>>   	return ret_val;
>>> --
>>> 2.38.1
>>>
>>>