netdev - Re: [PATCH net] net/sched: taprio: drop packets when tc mapping to empty queue in taprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230612213809.upnxxlsk6e4mih7p@skbuf>
Date: Tue, 13 Jun 2023 00:38:09 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Zhengchao Shao <shaozhengchao@...wei.com>
Cc: netdev@...r.kernel.org, vinicius.gomes@...el.com, jhs@...atatu.com,
	xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net] net/sched: taprio: drop packets when tc mapping to
 empty queue in taprio_enqueue

On Mon, Jun 12, 2023 at 11:31:15AM +0800, Zhengchao Shao wrote:
> As discussed in link [1], queues setting (0@0) means TC mapped to the
> "empty set" queue. We should drop the packets from TCs mapped to the
> "empty set" queue (0@0) during enqueue().
> 
> [1] https://lore.kernel.org/all/20230608062756.3626573-1-shaozhengchao@huawei.com/
> Fixes: 2f530df76c8c ("net/sched: taprio: give higher priority to higher TCs in software dequeue mode")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---

Is there any reason at all why this patch is needed?