netdev - Re: [PATCH net] net: ethernet: ti: am65-cpsw: Call of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75c8dba6-cfcc-977d-6e55-7b7c85689f3f@ti.com>
Date: Mon, 12 Jun 2023 12:51:26 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni
	<pabeni@...hat.com>, Roger Quadros <rogerq@...nel.org>,
        <netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        <s-vadapalli@...com>
Subject: Re: [PATCH net] net: ethernet: ti: am65-cpsw: Call of_node_put() on
 error path

Hello Dan,

Thank you for the fix.

On 12/06/23 12:48, Dan Carpenter wrote:
> This code returns directly but it should instead call of_node_put()
> to drop some reference counts.
> 
> Fixes: dab2b265dd23 ("net: ethernet: ti: am65-cpsw: Add support for SERDES configuration")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Siddharth Vadapalli <s-vadapalli@...com>

> ---
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> index 11cbcd9e2c72..bebcfd5e6b57 100644
> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> @@ -2068,7 +2068,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
>  		/* Initialize the Serdes PHY for the port */
>  		ret = am65_cpsw_init_serdes_phy(dev, port_np, port);
>  		if (ret)
> -			return ret;
> +			goto of_node_put;
>  
>  		port->slave.mac_only =
>  				of_property_read_bool(port_np, "ti,mac-only");

-- 
Regards,
Siddharth.