netdev - Re: [PATCH v2 iwl-next] ice: use ice_down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28e4be5a-66b3-a132-464b-40815d7c0e2c@intel.com>
Date: Tue, 13 Jun 2023 13:42:51 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, <anthony.l.nguyen@...el.com>,
	<magnus.karlsson@...el.com>
Subject: Re: [PATCH v2 iwl-next] ice: use ice_down_up() where applicable

On 6/13/23 13:35, Maciej Fijalkowski wrote:
> ice_change_mtu() is currently using a separate ice_down() and ice_up()
> calls to reflect changed MTU. ice_down_up() serves this purpose, so do
> the refactoring here.
> 
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>


> ---
> 
> v1->v2:
> - avoid setting ICE_VSI_DOWN bit as ice_down_up() covers it [Przemek]
> 
>   drivers/net/ethernet/intel/ice/ice_main.c | 18 +++---------------
>   1 file changed, 3 insertions(+), 15 deletions(-)