netdev - Re: [PATCH] drivers/thunder:improve-warning-message-in-device_for_each_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4aa86edd-5526-929d-8576-9d2b6f828eb0@huawei.com>
Date: Tue, 13 Jun 2023 20:52:52 +0800
From: Yunsheng Lin <linyunsheng@...wei.com>
To: Wang Ming <machel@...o.com>, Sunil Goutham <sgoutham@...vell.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	<linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
CC: <opensource.kernel@...o.com>
Subject: Re: [PATCH]
 drivers/thunder:improve-warning-message-in-device_for_each_child_node()

On 2023/6/13 20:38, Wang Ming wrote:
> In device_for_each_child_node(), it should have fwnode_handle_put()
> before break to prevent stale device node references from being
> left behind.
> 
> Signed-off-by: Wang Ming <machel@...o.com>

A Fixes tag seems necessary according to the commit log, and should
target the net branch using:

[PATCH net] drivers/thunder: improve-warning-message-in-device_for_each_child_node()

Also it seems confusing the 'improve' in the title suggest that it is not
a fix.

> ---
>  .../net/ethernet/cavium/thunder/thunder_bgx.c | 37 ++++++++++---------
>  1 file changed, 20 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index a317feb8d..d37ee2872 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -90,7 +90,7 @@ static const struct pci_device_id bgx_id_table[] = {
> 
>  MODULE_AUTHOR("Cavium Inc");
>  MODULE_DESCRIPTION("Cavium Thunder BGX/MAC Driver");
> -MODULE_LICENSE("GPL v2");
> +MODULE_LICENSE("GPL");

Is there any reason you changing the license here?

>  MODULE_VERSION(DRV_VERSION);
>  MODULE_DEVICE_TABLE(pci, bgx_id_table);
> 
> @@ -174,10 +174,10 @@ static struct bgx *get_bgx(int node, int bgx_idx)
>  }
> 
>  /* Return number of BGX present in HW */
> -unsigned bgx_get_map(int node)
> +unsigned int bgx_get_map(int node)

It seems to be unrelated change here, is the changing related to the
problem you are fixing?

>  {
>         int i;
> -       unsigned map = 0;
> +       unsigned int map = 0;

Same here.

> 
>         for (i = 0; i < max_bgx_per_node; i++) {
>                 if (bgx_vnic[(node * max_bgx_per_node) + i])
> @@ -600,9 +600,9 @@ static void bgx_lmac_handler(struct net_device *netdev)
>                 link_changed = -1;
> 
>         if (phydev->link &&
> -           (lmac->last_duplex != phydev->duplex ||
> -            lmac->last_link != phydev->link ||
> -            lmac->last_speed != phydev->speed)) {
> +               (lmac->last_duplex != phydev->duplex ||
> +               lmac->last_link != phydev->link ||
> +               lmac->last_speed != phydev->speed)) {

Same here.

>                         link_changed = 1;
>         }
> 
> @@ -783,7 +783,7 @@ static int bgx_lmac_xaui_init(struct bgx *bgx, struct lmac *lmac)
>                 bgx_reg_write(bgx, lmacid, BGX_SPUX_BR_PMD_LD_REP, 0x00);
>                 /* training enable */
>                 bgx_reg_modify(bgx, lmacid,
> -                              BGX_SPUX_BR_PMD_CRTL, SPU_PMD_CRTL_TRAIN_EN);
> +                                        BGX_SPUX_BR_PMD_CRTL, SPU_PMD_CRTL_TRAIN_EN);

Same here.
Please make sure it only contain change related to fixing the
problem.