netdev - Re: [PATCH net-next v2 3/3] ice: remove unnecessary check for old MAC == new MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4db2d627-782c-90c2-4826-76b9779149ce@intel.com>
Date: Tue, 13 Jun 2023 16:02:33 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Piotr Gardocki <piotrx.gardocki@...el.com>, <netdev@...r.kernel.org>
CC: <intel-wired-lan@...ts.osuosl.org>, <michal.swiatkowski@...ux.intel.com>,
	<pmenzel@...gen.mpg.de>, <kuba@...nel.org>, <maciej.fijalkowski@...el.com>,
	<anthony.l.nguyen@...el.com>, <simon.horman@...igine.com>,
	<aleksander.lobakin@...el.com>
Subject: Re: [PATCH net-next v2 3/3] ice: remove unnecessary check for old MAC
 == new MAC

On 6/13/23 14:24, Piotr Gardocki wrote:
> The check has been moved to core. The ndo_set_mac_address callback
> is not being called with new MAC address equal to the old one anymore.
> 
> Signed-off-by: Piotr Gardocki <piotrx.gardocki@...el.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_main.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index caafb12d9cc7..f0ba896a3f46 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5624,11 +5624,6 @@ static int ice_set_mac_address(struct net_device *netdev, void *pi)
>   	if (!is_valid_ether_addr(mac))
>   		return -EADDRNOTAVAIL;
>   
> -	if (ether_addr_equal(netdev->dev_addr, mac)) {
> -		netdev_dbg(netdev, "already using mac %pM\n", mac);
> -		return 0;
> -	}
> -
>   	if (test_bit(ICE_DOWN, pf->state) ||
>   	    ice_is_reset_in_progress(pf->state)) {
>   		netdev_err(netdev, "can't set mac %pM. device not ready\n",

I would expect one patch that adds check in the core, then one patch 
that removes it in all, incl non-intel, drivers; with CC to their 
respective maintainers (like Tony for intel, ./scripts/get_maintainer.pl 
will help)