netdev - Re: [PATCH net-next v2 2/4] net: hns3: fix hns3 driver header file not self-contained issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIiqMMDMAV+asw7o@corigine.com>
Date: Tue, 13 Jun 2023 19:41:04 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Hao Lan <lanhao@...wei.com>
Cc: netdev@...r.kernel.org, yisen.zhuang@...wei.com, salil.mehta@...wei.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, richardcochran@...il.com,
	wangpeiyang1@...wei.com, shenjian15@...wei.com,
	chenhao418@...wei.com, wangjie125@...wei.com, yuanjilin@...rlc.com,
	cai.huoqing@...ux.dev, xiujianfeng@...wei.com
Subject: Re: [PATCH net-next v2 2/4] net: hns3: fix hns3 driver header file
 not self-contained issue

On Mon, Jun 12, 2023 at 08:23:56PM +0800, Hao Lan wrote:
> From: Hao Chen <chenhao418@...wei.com>
> 
> Hns3 driver header file uses the structure of other files, but does
> not include corresponding file, which causes a check warning that the
> header file is not self-contained by clang-tidy checker.
> 
> For example,
> 
> Use command clang-tidy -checks=-*,header-should-self-contain
> -p $build_dir  $src_file

Hi Hao Lan,

I tried this with clang-tidy-16 and src_file=".../hns3_enet.c"
but i get an error:

  Error: no checks enabled.
  USAGE: clang-tidy-16 [options] <source0> [... <sourceN>]

I feel that I'm missing something obvious here.

...