netdev - Re: [PATCH net-next] ethtool: ioctl: account for sopass diff in set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0220ac1-147f-6521-a463-1d7c3e126661@broadcom.com>
Date: Mon, 12 Jun 2023 16:00:01 -0700
From: Justin Chen <justin.chen@...adcom.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Daniil Tatianin <d-tatianin@...dex-team.ru>, Marco Bonelli
 <marco@...eim.net>, Vincent Mailhol <mailhol.vincent@...adoo.fr>,
 Maxim Korotkov <korotkov.maxim.s@...il.com>, Gal Pressman <gal@...dia.com>,
 Jiri Pirko <jiri@...nulli.us>, Kuniyuki Iwashima <kuniyu@...zon.com>,
 Simon Horman <simon.horman@...igine.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] ethtool: ioctl: account for sopass diff in
 set_wol

On 6/12/23 3:28 PM, Andrew Lunn wrote:
> On Mon, Jun 12, 2023 at 02:37:00PM -0700, Justin Chen wrote:
>> sopass won't be set if wolopt doesn't change. This means the following
>> will fail to set the correct sopass.
>> ethtool -s eth0 wol s sopass 11:22:33:44:55:66
>> ethtool -s eth0 wol s sopass 22:44:55:66:77:88
>>
>> Make sure we call into the driver layer set_wol if sopass is different.
>>
>> Fixes: 55b24334c0f2 ("ethtool: ioctl: improve error checking for set_wol")
>> Signed-off-by: Justin Chen <justin.chen@...adcom.com>
>> ---
>>
>> Note: Tagged "Fixes" patch has not hit rc yet.
>>
>>   net/ethtool/ioctl.c | 3 ++-
> 
> Hi Justin
> 
> Does the netlink version get this correct?
>

Yup netlink gets this correct

> And just for my own curiosity, why are you so interested in the ioctl
> version, which is deprecated and not used by modern versions of
> ethtool?
>
No particular reason. I was working on another driver and was planning 
to remove the set_wol error checking in the driver layer when I realized 
netlink set_wol was already doing it. Then on further inspection I 
noticed the ioctl version doesn't do the same thing.

Justin

> 	Andrew

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4206 bytes)