netdev - Re: [PATCH net-next] net: tls: make the offload check helper take skb not socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d51d742f-5ccf-5a24-0cee-b4467fb83ba1@gmail.com>
Date: Wed, 14 Jun 2023 14:03:17 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 j.vosburgh@...il.com, andy@...yhouse.net, rajur@...lsio.com,
 ayush.sawal@...lsio.com, dmichail@...gible.com, borisp@...dia.com,
 saeedm@...dia.com, leon@...nel.org, simon.horman@...igine.com,
 john.fastabend@...il.com, anirudh.venkataramanan@...el.com,
 maxtram95@...il.com, gal@...dia.com, raeds@...dia.com, liorna@...dia.com,
 louis.peens@...igine.com, yinjun.zhang@...igine.com, na.wang@...igine.com,
 linux-rdma@...r.kernel.org, oss-drivers@...igine.com,
 Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net-next] net: tls: make the offload check helper take skb
 not socket



On 13/06/2023 23:50, Jakub Kicinski wrote:
> All callers of tls_is_sk_tx_device_offloaded() currently do
> an equivalent of:
> 
>   if (skb->sk && tls_is_skb_tx_device_offloaded(skb->sk))
> 
> Have the helper accept skb and do the skb->sk check locally.
> Two drivers have local static inlines with similar wrappers
> already.
> 
> While at it change the ifdef condition to TLS_DEVICE.
> Only TLS_DEVICE selects SOCK_VALIDATE_XMIT, so the two are
> equivalent. This makes removing the duplicated IS_ENABLED()
> check in funeth more obviously correct.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: j.vosburgh@...il.com
> CC: andy@...yhouse.net
> CC: rajur@...lsio.com
> CC: ayush.sawal@...lsio.com
> CC: dmichail@...gible.com
> CC: borisp@...dia.com
> CC: saeedm@...dia.com
> CC: leon@...nel.org
> CC: simon.horman@...igine.com
> CC: john.fastabend@...il.com
> CC: anirudh.venkataramanan@...el.com
> CC: maxtram95@...il.com
> CC: tariqt@...dia.com

Acked-by: Tariq Toukan <tariqt@...dia.com>

Thanks.