netdev - Re: [PATCH] cfg80211: cfg80211: strlcpy withreturn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADmuW3U6PpAhiOW-w55LcbbtmMXp5Wiq57MqZTgq0gDqj4G5vg@mail.gmail.com>
Date: Wed, 14 Jun 2023 09:46:31 -0400
From: Azeem Shaikh <azeemshaikh38@...il.com>
To: Kalle Valo <kvalo@...nel.org>
Cc: Johannes Berg <johannes@...solutions.net>, linux-hardening@...r.kernel.org, 
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] cfg80211: cfg80211: strlcpy withreturn

On Wed, Jun 14, 2023 at 3:40 AM Kalle Valo <kvalo@...nel.org> wrote:
>
> Azeem Shaikh <azeemshaikh38@...il.com> writes:
>
> > strlcpy() reads the entire source buffer first.
> > This read may exceed the destination size limit.
> > This is both inefficient and can lead to linear read
> > overflows if a source string is not NUL-terminated [1].
> > In an effort to remove strlcpy() completely [2], replace
> > strlcpy() here with strscpy().
> >
> > Direct replacement is safe here since WIPHY_ASSIGN is only used by
> > TRACE macros and the return values are ignored.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
> >
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@...il.com>
>
> The title should be:
>
> wifi: cfg80211: replace strlcpy() with strlscpy()
>

Ack. Sent out a v2.

> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches