netdev - Re: [PATCH net-next v3 0/3] optimize procedure of changing MAC address on interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZInhqR2RspvkMOYF@boxer>
Date: Wed, 14 Jun 2023 17:50:01 +0200
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: Piotr Gardocki <piotrx.gardocki@...el.com>
CC: <netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
	<przemyslaw.kitszel@...el.com>, <michal.swiatkowski@...ux.intel.com>,
	<pmenzel@...gen.mpg.de>, <kuba@...nel.org>, <anthony.l.nguyen@...el.com>,
	<simon.horman@...igine.com>, <aleksander.lobakin@...el.com>
Subject: Re: [PATCH net-next v3 0/3] optimize procedure of changing MAC
 address on interface

On Wed, Jun 14, 2023 at 04:52:59PM +0200, Piotr Gardocki wrote:
> The first patch adds an if statement in core to skip early when
> the MAC address is not being changes.
> The remaining patches remove such checks from Intel drivers
> as they're redundant at this point.
> 
> v3: removed "This patch ..." from first patch to simplify sentence.
> v2: modified check in core to support addresses of any length,
> removed redundant checks in i40e and ice

Any particular reason for not including my rev-by tags on driver patches?

> 
> Piotr Gardocki (3):
>   net: add check for current MAC address in dev_set_mac_address
>   i40e: remove unnecessary check for old MAC == new MAC
>   ice: remove unnecessary check for old MAC == new MAC
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ------
>  drivers/net/ethernet/intel/ice/ice_main.c   | 5 -----
>  net/core/dev.c                              | 2 ++
>  3 files changed, 2 insertions(+), 11 deletions(-)
> 
> -- 
> 2.34.1
>