netdev - Re: [PATCH net-next] gro: move the tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 14 Jun 2023 10:55:16 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Yunsheng Lin <linyunsheng@...wei.com>
Cc: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <richardbgobert@...il.com>
Subject: Re: [PATCH net-next] gro: move the tc_ext comparison to a helper

On Wed, 14 Jun 2023 20:58:53 +0800 Yunsheng Lin wrote:
> > +static void gro_list_prepare_tc_ext(const struct sk_buff *skb,
> > +				    const struct sk_buff *p,
> > +				    unsigned long *diffs)  
> 
> Isn't it more common to do something like below?
> 
> static unsigned long gro_list_prepare_tc_ext(const struct sk_buff *skb,
> 					     const struct sk_buff *p,
> 					     unsigned long diffs)
> 
> Is it because the resulting machine code is bigger for the above
> case?

Not really, just laziness - the above is more typing.
I guess avoiding output args is worth while, so between this and
Simon's comment - let me respin.
-- 
pw-bot: cr