netdev - Re: [PATCH iwl-next v4 02/10] ice: Add driver support for firmware changes for LAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 14 Jun 2023 21:44:21 +0200
From: Simon Horman <simon.horman@...igine.com>
To: "Ertman, David M" <david.m.ertman@...el.com>
Cc: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"daniel.machon@...rochip.com" <daniel.machon@...rochip.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH iwl-next v4 02/10] ice: Add driver support for firmware
 changes for LAG

On Wed, Jun 14, 2023 at 04:56:53PM +0000, Ertman, David M wrote:
> > -----Original Message-----
> > From: Simon Horman <simon.horman@...igine.com>
> > Sent: Wednesday, June 14, 2023 4:18 AM
> > To: Ertman, David M <david.m.ertman@...el.com>
> > Cc: intel-wired-lan@...ts.osuosl.org; daniel.machon@...rochip.com;
> > netdev@...r.kernel.org
> > Subject: Re: [PATCH iwl-next v4 02/10] ice: Add driver support for firmware
> > changes for LAG
> > 
> > On Fri, Jun 09, 2023 at 02:16:18PM -0700, Dave Ertman wrote:
> > 
> > ...
> > 
> > Hi Dave,
> > 
> > some minor feedback from my side.
> > 
> > > @@ -5576,10 +5579,18 @@ static int __init ice_module_init(void)
> > >  		return -ENOMEM;
> > >  	}
> > >
> > > +	ice_lag_wq = alloc_ordered_workqueue("ice_lag_wq", 0);
> > > +	if (!ice_lag_wq) {
> > > +		pr_err("Failed to create LAG workqueue\n");
> > 
> > Is the allocation failure already logged by core code?
> > If so, perhaps this is unnecessary?
> 
> I do not see any messaging from the core, so I should probably leave this here
> unless you can point out something I missed 😊

Let's keep it :)

...