netdev - Re: [PATCH iwl-next v4 05/10] ice: process events created by lag netdev event handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <887cbcd2-d01c-2736-d0de-660de80ef4d6@amd.com>
Date: Wed, 14 Jun 2023 14:24:23 -0700
From: Brett Creeley <bcreeley@....com>
To: Dave Ertman <david.m.ertman@...el.com>, intel-wired-lan@...ts.osuosl.org
Cc: daniel.machon@...rochip.com, simon.horman@...igine.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH iwl-next v4 05/10] ice: process events created by lag
 netdev event handler

On 6/9/2023 2:16 PM, Dave Ertman wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> Add in the function framework for the processing of LAG events.  Also add
> in helper function to perform common tasks.
> 
> Add the basis of the process of linking a lower netdev to an upper netdev.
> 
> Reviewed-by: Daniel Machon <daniel.machon@...rochip.com>
> Signed-off-by: Dave Ertman <david.m.ertman@...el.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_lag.c      | 535 +++++++++++++++---
>   drivers/net/ethernet/intel/ice/ice_lag.h      |   1 +
>   drivers/net/ethernet/intel/ice/ice_switch.c   |  10 +-
>   drivers/net/ethernet/intel/ice/ice_switch.h   |   3 +
>   drivers/net/ethernet/intel/ice/ice_virtchnl.c |   2 +
>   5 files changed, 478 insertions(+), 73 deletions(-)
> 

[...]

> +/**
> + * ice_lag_reclaim_vf_nodes - When interface leaving bond primary reclaims nodes
> + * @lag: primary interface lag struct
> + * @src_hw: HW struct for current node location
> + */
> +static void
> +ice_lag_reclaim_vf_nodes(struct ice_lag *lag, struct ice_hw *src_hw)
> +{
> +       struct ice_pf *pf;
> +       int i, tc;
> +
> +       if (!lag->primary || !src_hw)
> +               return;
> +
> +       pf = lag->pf;
> +       ice_for_each_vsi(pf, i)
> +               if (pf->vsi[i] && (pf->vsi[i]->type == ICE_VSI_VF ||
> +                                  pf->vsi[i]->type == ICE_VSI_SWITCHDEV_CTRL))
> +                       ice_for_each_traffic_class(tc)
> +                               ice_lag_reclaim_vf_tc(lag, src_hw, i, tc);

Seems like indentation got messed up here for ice_lag_reclaim_vf_tc()? 
Is this supposed to be under the if block?

> +}
> +


[...]