Message-ID: <ZIj8d8UhsZI2BPpR@x130>
Date: Tue, 13 Jun 2023 16:32:07 -0700
From: Saeed Mahameed <saeed@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Saeed Mahameed <saeedm@...dia.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org, Tariq Toukan <tariqt@...dia.com>,
	Shay Drory <shayd@...dia.com>, Moshe Shemesh <moshe@...dia.com>
Subject: Re: [net-next 14/15] net/mlx5: Light probe local SFs

On 12 Jun 10:51, Jakub Kicinski wrote:
>On Sat, 10 Jun 2023 21:15:57 -0700 Saeed Mahameed wrote:
>> On 10 Jun 00:01, Jakub Kicinski wrote:
>> >On Fri,  9 Jun 2023 18:42:53 -0700 Saeed Mahameed wrote:
>> >> In case user wants to configure the SFs, for example: to use only vdpa
>> >> functionality, he needs to fully probe a SF, configure what he wants,
>> >> and afterward reload the SF.
>> >>
>> >> In order to save the time of the reload, local SFs will probe without
>> >> any auxiliary sub-device, so that the SFs can be configured prior to
>> >> its full probe.
>> >
>> >I feel like we talked about this at least twice already, and I keep
>> >saying that the features should be specified when the device is
>> >spawned. Am I misremembering?
>>
>> I think we did talk about this, but after internal research we prefer to
>> avoid adding additional knobs, unless you insist :) ..
>> I think we already did a research and we feel that all of our users are
>> going to re-configure the SF anyway, so why not make all SFs start with
>> "blank state" ?
>
>In the container world, at least, I would have thought that the
>management daemon gets a full spec of the container its starting
>upfront. So going thru this spawn / config / futz / reset cycle
>is pure boilerplate pain.
>

That's the point of the series. create / config / spawn.

personally I like that the SF object is created blank, with dev handles
(devlink/aux) to configure it, and spawn it when ready.
I don't see a point of having an extra "blank state" devlink param.

>What use cases are you considering? More VM-oriented?
>

Mostly container oriented, and selecting the ULP stacks, e.g RDMA, VDPA,
virtio, netdev, etc .. 


>> >> The defaults of the enable_* devlink params of these SFs are set to
>> >> false.
>> >>
>> >> Usage example:
>> >
>> >Is this a real example? Because we have..
>> >
>> >> Create SF:
>> >> $ devlink port add pci/0000:08:00.0 flavour pcisf pfnum 0 sfnum 11
>> >
>> >sfnum 11 here
>>
>> This an arbitrary user index.
>>
>> >> $ devlink port function set pci/0000:08:00.0/32768 \
>> >
>> >then port is 32768
>>
>> This is the actual HW port index, our SFs indexing start with an offset.
>>
>> >>                hw_addr 00:00:00:00:00:11 state active
>> >>
>> >> Enable ETH auxiliary device:
>> >> $ devlink dev param set auxiliary/mlx5_core.sf.1 \
>> >
>> >and instance is sf.1
>>
>> This was the first SF aux dev to be created on the system. :/
>>
>> It's a mess ha...
>>
>> Maybe we need to set the SF aux device index the same as the user index.
>> But the HW/port index will always be different, otherwise we will need a map
>> inside the driver.
>
>It'd be best to synchronously return to the user what the ID of the
>allocated entity is. It should be possible with some core changes to
>rig up devlink to return the sfnum and port ID. But IDK about the new
>devlink instance :(

I think that's possible, let me ask the team to take a shot at this.. 

I am not sure I understand what you mean by "new devlink instance".

SF creation will result in spawning two devlink handles, the SF function port of
on the eswitch and the SF device devlink instance..

Powered by blists - more mailing lists