netdev - [PATCH v1] drivers:net:dsa:Fix resource leaks in fwnode_for_each_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230615070512.6634-1-machel@vivo.com>
Date: Thu, 15 Jun 2023 15:04:58 +0800
From: Wang Ming <machel@...o.com>
To: Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Wang Ming <machel@...o.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: [PATCH v1] drivers:net:dsa:Fix resource leaks in fwnode_for_each_child_node() loops 

 The fwnode_for_each_child_node loop in qca8k_setup_led_ctrl should
 have fwnode_handle_put() before return which could avoid resource leaks.
 This patch could fix this bug.

Signed-off-by: Wang Ming <machel@...o.com>
---
 drivers/net/dsa/qca/qca8k-leds.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/qca/qca8k-leds.c b/drivers/net/dsa/qca/qca8k-leds.c
index 6f02029b4..d24ee5df9 100644
--- a/drivers/net/dsa/qca/qca8k-leds.c
+++ b/drivers/net/dsa/qca/qca8k-leds.c
@@ -450,8 +450,10 @@ qca8k_setup_led_ctrl(struct qca8k_priv *priv)
                 * the correct port for LED setup.
                 */
                ret = qca8k_parse_port_leds(priv, port, qca8k_port_to_phy(port_num));
-               if (ret)
+               if (ret) {
+                       fwnode_handle_put(port);
                        return ret;
+               }
        }

        return 0;
--
2.25.1

________________________________
本邮件及其附件内容可能含有机密和/或隐私信息，仅供指定个人或机构使用。若您非发件人指定收件人或其代理人，请勿使用、传播、复制或存储此邮件之任何内容或其附件。如您误收本邮件，请即以回复或电话方式通知发件人，并将原始邮件、附件及其所有复本删除。谢谢。
The contents of this message and any attachments may contain confidential and/or privileged information and are intended exclusively for the addressee(s). If you are not the intended recipient of this message or their agent, please note that any use, dissemination, copying, or storage of this message or its attachments is not allowed. If you receive this message in error, please notify the sender by reply the message or phone and delete this message, any attachments and any copies immediately.
Thank you