netdev - Re: [PATCH net-next v3 0/3] optimize procedure of changing MAC address on interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 15 Jun 2023 10:51:28 +0200
From: Piotr Gardocki <piotrx.gardocki@...el.com>
To: Simon Horman <simon.horman@...igine.com>
CC: <netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
	<przemyslaw.kitszel@...el.com>, <michal.swiatkowski@...ux.intel.com>,
	<pmenzel@...gen.mpg.de>, <kuba@...nel.org>, <maciej.fijalkowski@...el.com>,
	<anthony.l.nguyen@...el.com>, <aleksander.lobakin@...el.com>
Subject: Re: [PATCH net-next v3 0/3] optimize procedure of changing MAC
 address on interface

On 15.06.2023 09:31, Simon Horman wrote:
> On Wed, Jun 14, 2023 at 04:52:59PM +0200, Piotr Gardocki wrote:
>> The first patch adds an if statement in core to skip early when
>> the MAC address is not being changes.
>> The remaining patches remove such checks from Intel drivers
>> as they're redundant at this point.
> 
> Hi Pitor,
> 
> I am wondering if you audited other drivers to see if they
> could also be updated in a similar way to the Intel changes
> in this patch-set.

Hi Simon,

We already discussed this in "[PATCH net-next v2 3/3]". Other drivers
should be audited at one point, but there are hundreds of ndo_set_mac_address
callbacks in kernel and I don't have resources to review all of them. I just
fixed Intel drivers for now.
When this patch set is applied someone else can work on that.