netdev - Re: [PATCH v1] drivers:net:ethernet:Remove unneeded code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 15 Jun 2023 15:40:11 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Wang Ming <machel@...o.com>
Cc: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers:net:ethernet:Remove unneeded code

On Thu, Jun 15, 2023 at 04:40:56PM +0800, Wang Ming wrote:
> Remove unused helper code.
> Fix the following coccicheck warning:
> 
> drivers/net/ethernet/mellanox/mlx5/core/eswitch.c:808:34-35:
> WARNING: unneeded memset.
> 
> Signed-off-by: Wang Ming <machel@...o.com>

Hi Wang Ming,

unfortunately your patch has been whitespace mangled - tabs have been
converted into 8 spaces. Possibly this was done by your mail client
or mail server. In any case the result is that the patch doesn't apply.
And unfortunately that breaks our processes.

Also, assuming that as this patch is a not a bug fix, it is targeted at the
"net-next", as opposed to "net", tree. This should be noted in the subject.

        Subject: [PATCH net-next v2] ...

Looking at the git history of eswitch.c, I think that
a better prefix for the patch is "mlx5/core: E-Switch, "

        Subject: [PATCH net-next v2] mlx5/core: E-Switch, ...

> ---
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> index 31956cd9d..ae0939488 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> @@ -805,7 +805,6 @@ static int mlx5_esw_vport_caps_get(struct mlx5_eswitch *esw, struct mlx5_vport *
>         hca_caps = MLX5_ADDR_OF(query_hca_cap_out, query_ctx, capability);
>         vport->info.roce_enabled = MLX5_GET(cmd_hca_cap, hca_caps, roce);
> 
> -       memset(query_ctx, 0, query_out_sz);

I'm not saying this change is wrong.
But I am saying that it's not immediately obvious to me why
it is correct. And in any case, I think the patch description
needs to describe why it is correct.

Likewise, "Remove unneeded code" seems rather terse.

Also, FWIIW, I don't see this when using coccicheck.
But perhaps that's just me. I'm using:

 make C=2 CHECK=scripts/coccicheck drivers/net/ethernet/mellanox/mlx5/core/eswitch.o

>         err = mlx5_vport_get_other_func_cap(esw->dev, vport->vport, query_ctx,
>                                             MLX5_CAP_GENERAL_2);
>         if (err)

Please consider waiting for further review, and as appropriate,
addressing the problems above and reposting your patch.

-- 
pw-bot: cr