netdev - Re: [PATCH net-next] xsk: Remove unused inline function xsk_buff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIsiyKfr/WdzKlji@corigine.com>
Date: Thu, 15 Jun 2023 16:40:08 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: YueHaibing <yuehaibing@...wei.com>, bjorn@...nel.org,
	magnus.karlsson@...el.com, jonathan.lemon@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
	hawk@...nel.org, john.fastabend@...il.com, netdev@...r.kernel.org,
	bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
	maxtram95@...il.com
Subject: Re: [PATCH net-next] xsk: Remove unused inline function
 xsk_buff_discard()

On Thu, Jun 15, 2023 at 03:51:49PM +0200, Maciej Fijalkowski wrote:
> On Thu, Jun 15, 2023 at 03:49:23PM +0200, Maciej Fijalkowski wrote:
> > On Thu, Jun 15, 2023 at 08:46:12PM +0800, YueHaibing wrote:
> > > commit f2f167583601 ("xsk: Remove unused xsk_buff_discard")
> > > left behind this, remove it.
> > > 
> > > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > 
> > Yeah this is a stub for !CONFIG_XDP_SOCKETS...
> 
> Wait, I am not sure if this should go to bpf tree and have fixes tag
> pointing to the cited commit?
> 
> Functionally this commit does not fix anything but it feels that
> f2f167583601 was incomplete.

FWIIW, I think that bpf-next is appropriate for this patch
as it doesn't address a bug.