netdev - Re: [PATCH v1] drivers:net:dsa:Fix resource leaks in fwnode_for_each_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230615203649.amziv2aqzi3vishu@skbuf>
Date: Thu, 15 Jun 2023 23:36:49 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Simon Horman <simon.horman@...igine.com>
Cc: Wang Ming <machel@...o.com>, Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers:net:dsa:Fix resource leaks in
 fwnode_for_each_child_node() loops

Hi Simon,

On Thu, Jun 15, 2023 at 03:03:15PM +0200, Simon Horman wrote:
> On Thu, Jun 15, 2023 at 03:04:58PM +0800, Wang Ming wrote:
> >  The fwnode_for_each_child_node loop in qca8k_setup_led_ctrl should
> >  have fwnode_handle_put() before return which could avoid resource leaks.
> >  This patch could fix this bug.
> > 
> > Signed-off-by: Wang Ming <machel@...o.com>
> 
> Hi Wang Ming,
> 
> unfortunately your patch has been whitespace mangled - tabs have been
> converted into 8 spaces. Possibly this was done by your mail client
> or mail server. In any case the result is that the patch doesn't apply.
> And unfortunately that breaks our processes.
> 
> Also, I'm assuming that as this patch is a fix, it is targeted at the
> "net", as opposed to "net-next", tree. This should be noted in the subject.
> 
> 	Subject: [PATCH net v2] ...
> 
> Lastly, looking at the git history of qca8k-leds.c, I think that
> a better prefix for the patch is "net: dsa: qca8k: ".
> 
> 	Subject: [PATCH net v2] net: dsa: qca8k: ...
> 
> Please consider addressing the problems and reposting your patch.
> 
> -- 
> pw-bot: changes-requested

I think that according to the disclaimer text, you as a subscriber to
the mailing list should have deleted this message instead of commenting
on it :)

| The contents of this message and any attachments may contain confidential
| and/or privileged information and are intended exclusively for the
| addressee(s). If you are not the intended recipient of this message or
| their agent, please note that any use, dissemination, copying, or storage
| of this message or its attachments is not allowed.
| If you receive this message in error, please notify the sender by reply
| the message or phone and delete this message, any attachments and any
| copies immediately.

Seriously now, that has to go when posting to a mailing list whose archives
can be seen on the world wide web.
https://lore.kernel.org/netdev/20230615070512.6634-1-machel@vivo.com/

2 comments from my side on the actual patch.

1. There is an indentation of 1 space in the commit message which
   doesn't belong there.

2. I believe that the "ports" fwnode_handle is also leaked, both in the
   error as well as in the success case.

And one more process-related observation. You must find the commit which
introduced the problem and add:

Fixes: 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support")

and also CC the author of that patch.