netdev - Re: [PATCH net-next] eth: fs_enet: fix print format for resource size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230614212259.1e19900c@kernel.org>
Date: Wed, 14 Jun 2023 21:22:59 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, pantelis.antoniou@...il.com,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH net-next] eth: fs_enet: fix print format for resource
 size

On Wed, 14 Jun 2023 21:02:33 -0700 Randy Dunlap wrote:
> On 6/14/23 20:52, Jakub Kicinski wrote:
> > Randy forwarded report from Stephen that on PowerPC:  
> 
> Stephen forwarded report from Randy?
> 
> netdev & pantelis were cc-ed...

Ah, I misread, you were reporting to Stephen the status for the latest
linux-next!

https://lore.kernel.org/all/8f9f8d38-d9c7-9f1b-feb0-103d76902d14@infradead.org/

Seems obvious in hindsight, sorry. I'll reword when applying.

> > drivers/net/ethernet/freescale/fs_enet/mii-fec.c: In function 'fs_enet_mdio_probe':
> > drivers/net/ethernet/freescale/fs_enet/mii-fec.c:130:50: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Wformat=]
> >   130 |         snprintf(new_bus->id, MII_BUS_ID_SIZE, "%x", res.start);
> >       |                                                 ~^   ~~~~~~~~~
> >       |                                                  |      |
> >       |                                                  |      resource_size_t {aka long long unsigned int}
> >       |                                                  unsigned int
> >       |                                                 %llx
> > 
> > Use the right print format.
> > 
> > Untested, I can't repro this warning myself. With or without
> > the patch mpc512x_defconfig builds just fine.
> > 
> > Link: https://lore.kernel.org/all/8f9f8d38-d9c7-9f1b-feb0-103d76902d14@infradead.org/
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > ---
> > CC: Randy Dunlap <rdunlap@...radead.org>
> > CC: pantelis.antoniou@...il.com
> > CC: linuxppc-dev@...ts.ozlabs.org  
> 
> I'm using gcc-12.2.0.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Acked-by: Randy Dunlap <rdunlap@...radead.org>
> Tested-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thank you! GCC 11.1 here, FWIW.