netdev - Re: [PATCH 0/5] Rust abstractions for network device drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d0eba7d-ac43-d944-d105-008978f4402e@ryhl.io>
Date: Fri, 16 Jun 2023 14:28:19 +0200
From: Alice Ryhl <alice@...l.io>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, rust-for-linux@...r.kernel.org,
 aliceryhl@...gle.com, andrew@...n.ch, miguel.ojeda.sandonis@...il.com,
 FUJITA Tomonori <fujita.tomonori@...il.com>
Subject: Re: [PATCH 0/5] Rust abstractions for network device drivers

On 6/15/23 08:01, Jakub Kicinski wrote:> I was hoping someone from the 
Rust side is going to review this.
> We try to review stuff within 48h at netdev, and there's no review :S

I'm from the Rust side, and I intend to review this, but I've taken this 
week off, so it wont be until next week.

> What is this supposed to be doing? Who needs to _set_ unrelated
> statistics from a function call? Yet no reviewer is complaining
> which either means I don't understand, or people aren't really 
> paying attention 🙁

It can sometimes be necessary to wrap loads or stores in function calls 
when working over the FFI boundary. However, Rust is very aggressive 
about inlining this kind of thing, so it shouldn't have any actual 
performance cost.

As for this being a single function rather than four functions, that's 
definitely a debatable decision. You would only do that if it makes 
sense to merge them together and if you would always assign all of them 
together. I don't know enough about these fields to say whether it makes 
sense here.

Alice