netdev - Re: [PATCH V5] net: phy: Add sysfs attribute for PHY c45 identifiers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZIx3E/KAU0aHSxqg@shell.armlinux.org.uk>
Date: Fri, 16 Jun 2023 15:52:03 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Jianhui Zhao <zhaojh329@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5] net: phy: Add sysfs attribute for PHY c45 identifiers.

On Fri, Jun 16, 2023 at 10:40:17PM +0800, Jianhui Zhao wrote:
> If a phydevice use c45, its phy_id property is always 0, so
> this adds a c45_ids sysfs attribute group contains mmd id
> attributes from mmd0 to mmd31 to MDIO devices. Note that only
> mmd with valid value will exist. This attribute group can be
> useful when debugging problems related to phy drivers.
> 
> Likes this:
> /sys/bus/mdio_bus/devices/mdio-bus:05/c45_ids/mmd1
> /sys/bus/mdio_bus/devices/mdio-bus:05/c45_ids/mmd2
> ...
> /sys/bus/mdio_bus/devices/mdio-bus:05/c45_ids/mmd31
> 
> Signed-off-by: Jianhui Zhao <zhaojh329@...il.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Reviewed-by: Russell King <linux@...linux.org.uk>

NAK, because you haven't listened to all of the feedback that's been
given to you.

1. You haven't taken on my suggestion for reformatting the if().
2. You haven't updated my Reviewed-by, which in any case was conditional
   on the acceptance of all of my review comments.
3. You haven't removed Andrew's reviewed-by which he hasn't given you,
   and thus your commit message is a lie.
4. You haven't obeyed the "do not repost in under 24 hours"

I do not expect to see you post a V6 before at the very earliest Monday,
and if you do, I will NAK it purely on that point, and you will get an
even stronger email from me.

Stop adding unnecessarily to reviewers workloads.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!