netdev - Re: [PATCH v10 vfio 0/7] pds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91f8f8ba-dfc1-2d42-3aa7-f7c5eebf9a56@amd.com>
Date: Fri, 16 Jun 2023 13:06:04 -0700
From: Brett Creeley <bcreeley@....com>
To: "Tian, Kevin" <kevin.tian@...el.com>,
 Brett Creeley <brett.creeley@....com>,
 "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
 "jgg@...dia.com" <jgg@...dia.com>, "yishaih@...dia.com"
 <yishaih@...dia.com>,
 "shameerali.kolothum.thodi@...wei.com" <shameerali.kolothum.thodi@...wei.com>
Cc: "shannon.nelson@....com" <shannon.nelson@....com>
Subject: Re: [PATCH v10 vfio 0/7] pds_vfio driver

On 6/15/2023 11:47 PM, Tian, Kevin wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
>> From: Brett Creeley <brett.creeley@....com>
>> Sent: Saturday, June 3, 2023 6:03 AM
>>
>> This is a patchset for a new vendor specific VFIO driver
>> (pds_vfio) for use with the AMD/Pensando Distributed Services Card
>> (DSC). This driver makes use of the pds_core driver.
>>
>> This driver will use the pds_core device's adminq as the VFIO
>> control path to the DSC. In order to make adminq calls, the VFIO
>> instance makes use of functions exported by the pds_core driver.
>>
>> In order to receive events from pds_core, the pds_vfio driver
>> registers to a private notifier. This is needed for various events
>> that come from the device.
>>
>> An ASCII diagram of a VFIO instance looks something like this and can
>> be used with the VFIO subsystem to provide the VF device VFIO and live
>> migration support.
>>
>>                                 .------.  .-----------------------.
>>                                 | QEMU |--|  VM  .-------------.  |
>>                                 '......'  |      |   Eth VF    |  |
>>                                    |      |      .-------------.  |
>>                                    |      |      |  SR-IOV VF  |  |
>>                                    |      |      '-------------'  |
>>                                    |      '------------||---------'
>>                                 .--------------.       ||
>>                                 |/dev/<vfio_fd>|       ||
>>                                 '--------------'       ||
>> Host Userspace                         |              ||
>> ===================================================   ||
>> Host Kernel                            |              ||
>>                                    .--------.          ||
>>                                    |vfio-pci|          ||
>>                                    '--------'          ||
>>         .------------------.           ||              ||
>>         |   | exported API |<----+     ||              ||
>>         |   '--------------|     |     ||              ||
>>         |                  |    .-------------.        ||
>>         |     pds_core     |--->|   pds_vfio  |        ||
>>         '------------------' |  '-------------'        ||
>>                 ||           |         ||              ||
>>               09:00.0     notifier    09:00.1          ||
>> == PCI ===============================================||=====
>>                 ||                     ||              ||
>>            .----------.          .----------.          ||
>>      ,-----|    PF    |----------|    VF    |-------------------,
>>      |     '----------'          '----------'  |       VF       |
>>      |                     DSC                 |  data/control  |
>>      |                                         |      path      |
>>      -----------------------------------------------------------
>>
> 
> why is "VF data/control path" drawn out of the VF box?

Just a mistake in the drawing. I can fix it. Thanks.
>