netdev - Re: [PATCH net-next] ipv6: also use netdev_hold() in ip6_route_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230616132420.3add6e75@kernel.org>
Date: Fri, 16 Jun 2023 13:24:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org, eric.dumazet@...il.com, syzbot
 <syzkaller@...glegroups.com>, David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net-next] ipv6: also use netdev_hold() in
 ip6_route_check_nh()

On Fri, 16 Jun 2023 08:57:52 +0000 Eric Dumazet wrote:
> In blamed commit, we missed the fact that ip6_validate_gw()
> could change dev under us from ip6_route_check_nh()
> 
> In this fix, I use GFP_ATOMIC in order to not pass too many additional
> arguments to ip6_validate_gw() and ip6_route_check_nh() only
> for a rarely used debug feature.

Eeh.

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

Thank you!