netdev - Re: [Intel-wired-lan] [PATCH iwl-next v5 05/10] ice: process events created by lag netdev event handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 16 Jun 2023 13:47:58 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Dave Ertman <david.m.ertman@...el.com>, <intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, <bcreeley@....com>,
	<daniel.machon@...rochip.com>, <simon.horman@...igine.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 05/10] ice: process events
 created by lag netdev event handler

On 6/15/2023 9:29 AM, Dave Ertman wrote:

...

> +static void
> +ice_lag_monitor_rdma(struct ice_lag *lag, void *ptr)
> +{
> +	struct netdev_notifier_changeupper_info *info;
> +	struct net_device *netdev;
> +	struct ice_pf *pf;
> +
> +	info = ptr;
> +	netdev = netdev_notifier_info_to_dev(ptr);
> +
> +	if (netdev != lag->netdev)
>   		return;
> -	}
>   
>   	if (info->linking)
> -		ice_lag_link(lag, info);
> +		ice_clear_rdma_cap(pf);
>   	else
> -		ice_lag_unlink(lag, info);
> -
> -	ice_display_lag_info(lag);
> +		ice_set_rdma_cap(pf);

pf isn't being assigned. Clang reports:

+../drivers/net/ethernet/intel/ice/ice_lag.c:657:22: warning: variable 
'pf' is uninitialized when used here [-Wuninitialized]
+                ice_clear_rdma_cap(pf);
+                                   ^~
+../drivers/net/ethernet/intel/ice/ice_lag.c:648:19: note: initialize 
the variable 'pf' to silence this warning
+        struct ice_pf *pf;
+                         ^
+                          = NULL
+1 warning generated.

>   }
>   
>   /**