netdev - Re: [PATCH net-next 01/17] net: Copy slab data for sendmsg(MSG_SPLICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZI26hJuixlQHOjk4@corigine.com>
Date: Sat, 17 Jun 2023 15:52:04 +0200
From: Simon Horman <simon.horman@...igine.com>
To: David Howells <dhowells@...hat.com>
Cc: netdev@...r.kernel.org, Alexander Duyck <alexander.duyck@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	David Ahern <dsahern@...nel.org>,
	Matthew Wilcox <willy@...radead.org>, Jens Axboe <axboe@...nel.dk>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Menglong Dong <imagedong@...cent.com>
Subject: Re: [PATCH net-next 01/17] net: Copy slab data for
 sendmsg(MSG_SPLICE_PAGES)

On Sat, Jun 17, 2023 at 07:43:15AM +0100, David Howells wrote:
> Simon Horman <simon.horman@...igine.com> wrote:
> 
> > > +	cache = get_cpu_ptr(&skb_splice_frag_cache);
> ...
> > > +	put_cpu_ptr(skb_splice_frag_cache);
> > 
> > Hi David,
> > 
> > I don't think it makes any difference at run-time.
> > But to keep Sparse happy, perhaps this ought to be put_cpu_var()
> 
> Actually, the problem is a missing "&".  I think I should use put_cpu_ptr() to
> match get_cpu_ptr().  It doesn't crash because the argument is ignored.

Thanks David, I agree that is a better idea.