netdev - question: potential memory leak in ngbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <449528fe-1f8e-490a-6e53-e5aa43fbabdc@huawei.com>
Date: Sat, 17 Jun 2023 11:31:07 +0800
From: shaozhengchao <shaozhengchao@...wei.com>
To: <jiawenwu@...stnetic.com>, netdev <netdev@...r.kernel.org>
CC: <mengyuanlou@...-swift.com>, David Miller <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, YueHaibing <yuehaibing@...wei.com>
Subject: question: potential memory leak in ngbe_probe?

Hi Jiawen:
	When I review the wangxun driver code, I found when
wx_check_flash_load() or wx_mng_present() e.g. failed in 
ngbe_probe(),RSS key that allcated in ngbe_sw_init() is not released.
Is there a possibility of a memory leak?
I thing add kfree() inthe error path to release the RSS key will be OK.
Is anything I missed?

Thank you.

Zhengchao Shao