netdev - Re: [PATCH v1 net-next 1/5] ipv6: rpl: Remove pskb(_may)?_pull() in ipv6_rpl_srh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230617010014.00f34757@kernel.org>
Date: Sat, 17 Jun 2023 01:00:14 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, David Ahern
 <dsahern@...nel.org>, Kuniyuki Iwashima <kuni1840@...il.com>,
 <netdev@...r.kernel.org>
Subject: Re: [PATCH v1 net-next 1/5] ipv6: rpl: Remove pskb(_may)?_pull() in
 ipv6_rpl_srh_rcv().

On Wed, 14 Jun 2023 16:01:03 -0700 Kuniyuki Iwashima wrote:
> -	if (!pskb_may_pull(skb, ipv6_rpl_srh_size(n, hdr->cmpri,
> -						  hdr->cmpre))) {

Are we checking that 

	ipv6_rpl_srh_size(n, hdr->cmpri, hdr->cmpre) < (hdrlen + 1) << 3

somewhere?

also nit:

> As Eric Dumazet pointed out [0], ipv6_rthdr_rcv() pulls these data
> 
>   - Segment Routing Header : 8
>   - Hdr Ext Len            : skb_transport_header(skb)[1] << 3

+1 missing here, AFAICT