netdev - Re: [PATCH net-next v2 10/17] nvme: Use sendmsg(MSG_SPLICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <755077.1687109321@warthog.procyon.org.uk>
Date: Sun, 18 Jun 2023 18:28:41 +0100
From: David Howells <dhowells@...hat.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: dhowells@...hat.com, netdev@...r.kernel.org,
    Alexander Duyck <alexander.duyck@...il.com>,
    "David S. Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
    Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>,
    Matthew Wilcox <willy@...radead.org>, Jens Axboe <axboe@...nel.dk>,
    linux-mm@...ck.org, linux-kernel@...r.kernel.org,
    Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
    Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
    Chaitanya Kulkarni <kch@...dia.com>, linux-nvme@...ts.infradead.org
Subject: Re: [PATCH net-next v2 10/17] nvme: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage

Willem de Bruijn <willemdebruijn.kernel@...il.com> wrote:

>     struct bio_vec bvec;
>     struct msghdr msg = { .msg_flags = MSG_SPLICE_PAGES | ... };
> 
>     ..
> 
>     bvec_set_virt
>     iov_iter_bvec
>     sock_sendmsg
> 
> is a frequent pattern. Does it make sense to define a wrapper? Same for bvec_set_page.

I dunno.  I'm trying to move towards aggregating multiple pages in a bvec
before calling sendmsg if possible rather than doing it one page at a time,
but it's easier and more obvious in some places than others.

David