netdev - Re: [PATCH net-next v0 3/3] net: phy: marvell: Add support for offloading LED blinking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d48ac5aa-c420-4d7d-97fe-e890bb8d9604@lunn.ch>
Date: Sun, 18 Jun 2023 22:28:24 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: netdev <netdev@...r.kernel.org>, ansuelsmth@...il.com,
	Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH net-next v0 3/3] net: phy: marvell: Add support for
 offloading LED blinking

> Hi Andrew,
> 
> What is the effect of this patch when LEDs are configured via the
> existing DT property that allows arbitary register writes in this
> driver?
> 
> There are a number of DTs that configure the LEDs this way, and
> I don't think we would wish to regress that established configuration.

These patches only do anything if there is an LED subnode in the PHY
node in DT. So there should not be an changes by default.

If you have both 'marvell,reg-init' poking values into registers, and
describe the LEDs in DT, then i would expect some change in
behaviour. But no existing DT files do that.

	 Andrew