| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Jun 2023 02:54:02 +0800
From: kernel test robot <lkp@...el.com>
To: Zhengchao Shao <shaozhengchao@...wei.com>, netdev@...r.kernel.org,
jiawenwu@...stnetic.com, mengyuanlou@...-swift.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, weiyongjun1@...wei.com,
yuehaibing@...wei.com, shaozhengchao@...wei.com
Subject: Re: [PATCH net-next] net: txgbe: remove unused buffer in
txgbe_calc_eeprom_checksum
Hi Zhengchao,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Zhengchao-Shao/net-txgbe-remove-unused-buffer-in-txgbe_calc_eeprom_checksum/20230619-165935
base: net-next/main
patch link: https://lore.kernel.org/r/20230619085709.104271-1-shaozhengchao%40huawei.com
patch subject: [PATCH net-next] net: txgbe: remove unused buffer in txgbe_calc_eeprom_checksum
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230620/202306200242.FXsHokaJ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230620/202306200242.FXsHokaJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306200242.FXsHokaJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c: In function 'txgbe_calc_eeprom_checksum':
>> drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c:163:13: warning: unused variable 'buffer_size' [-Wunused-variable]
163 | u32 buffer_size = 0;
| ^~~~~~~~~~~
vim +/buffer_size +163 drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c
049fe5365324c8 Jiawen Wu 2022-10-31 152
049fe5365324c8 Jiawen Wu 2022-10-31 153 /**
049fe5365324c8 Jiawen Wu 2022-10-31 154 * txgbe_calc_eeprom_checksum - Calculates and returns the checksum
9607a3e62645c2 Jiawen Wu 2023-01-06 155 * @wx: pointer to hardware structure
049fe5365324c8 Jiawen Wu 2022-10-31 156 * @checksum: pointer to cheksum
049fe5365324c8 Jiawen Wu 2022-10-31 157 *
049fe5365324c8 Jiawen Wu 2022-10-31 158 * Returns a negative error code on error
049fe5365324c8 Jiawen Wu 2022-10-31 159 **/
9607a3e62645c2 Jiawen Wu 2023-01-06 160 static int txgbe_calc_eeprom_checksum(struct wx *wx, u16 *checksum)
049fe5365324c8 Jiawen Wu 2022-10-31 161 {
049fe5365324c8 Jiawen Wu 2022-10-31 162 u16 *eeprom_ptrs = NULL;
049fe5365324c8 Jiawen Wu 2022-10-31 @163 u32 buffer_size = 0;
049fe5365324c8 Jiawen Wu 2022-10-31 164 u16 *local_buffer;
049fe5365324c8 Jiawen Wu 2022-10-31 165 int status;
049fe5365324c8 Jiawen Wu 2022-10-31 166 u16 i;
049fe5365324c8 Jiawen Wu 2022-10-31 167
9607a3e62645c2 Jiawen Wu 2023-01-06 168 wx_init_eeprom_params(wx);
049fe5365324c8 Jiawen Wu 2022-10-31 169
049fe5365324c8 Jiawen Wu 2022-10-31 170 eeprom_ptrs = kvmalloc_array(TXGBE_EEPROM_LAST_WORD, sizeof(u16),
049fe5365324c8 Jiawen Wu 2022-10-31 171 GFP_KERNEL);
049fe5365324c8 Jiawen Wu 2022-10-31 172 if (!eeprom_ptrs)
049fe5365324c8 Jiawen Wu 2022-10-31 173 return -ENOMEM;
049fe5365324c8 Jiawen Wu 2022-10-31 174 /* Read pointer area */
f5b8ea1c5022db Zhengchao Shao 2023-06-19 175 status = wx_read_ee_hostif_buffer(wx, 0, TXGBE_EEPROM_LAST_WORD, eeprom_ptrs);
049fe5365324c8 Jiawen Wu 2022-10-31 176 if (status != 0) {
9607a3e62645c2 Jiawen Wu 2023-01-06 177 wx_err(wx, "Failed to read EEPROM image\n");
a068d33e542f5d YueHaibing 2022-11-05 178 kvfree(eeprom_ptrs);
049fe5365324c8 Jiawen Wu 2022-10-31 179 return status;
049fe5365324c8 Jiawen Wu 2022-10-31 180 }
049fe5365324c8 Jiawen Wu 2022-10-31 181 local_buffer = eeprom_ptrs;
049fe5365324c8 Jiawen Wu 2022-10-31 182
049fe5365324c8 Jiawen Wu 2022-10-31 183 for (i = 0; i < TXGBE_EEPROM_LAST_WORD; i++)
9607a3e62645c2 Jiawen Wu 2023-01-06 184 if (i != wx->eeprom.sw_region_offset + TXGBE_EEPROM_CHECKSUM)
049fe5365324c8 Jiawen Wu 2022-10-31 185 *checksum += local_buffer[i];
049fe5365324c8 Jiawen Wu 2022-10-31 186
a068d33e542f5d YueHaibing 2022-11-05 187 if (eeprom_ptrs)
a068d33e542f5d YueHaibing 2022-11-05 188 kvfree(eeprom_ptrs);
a068d33e542f5d YueHaibing 2022-11-05 189
5e2ea7801faccc YueHaibing 2022-11-05 190 if (*checksum > TXGBE_EEPROM_SUM)
049fe5365324c8 Jiawen Wu 2022-10-31 191 return -EINVAL;
049fe5365324c8 Jiawen Wu 2022-10-31 192
5e2ea7801faccc YueHaibing 2022-11-05 193 *checksum = TXGBE_EEPROM_SUM - *checksum;
5e2ea7801faccc YueHaibing 2022-11-05 194
049fe5365324c8 Jiawen Wu 2022-10-31 195 return 0;
049fe5365324c8 Jiawen Wu 2022-10-31 196 }
049fe5365324c8 Jiawen Wu 2022-10-31 197
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists