netdev - Re: [PATCH v2 02/12] mm: introduce execmem_text_alloc() and jit_text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 19 Jun 2023 13:18:15 -0700
From: Nadav Amit <nadav.amit@...il.com>
To: Andy Lutomirski <luto@...nel.org>,
 Song Liu <song@...nel.org>
Cc: Mike Rapoport <rppt@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Kees Cook <keescook@...omium.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Catalin Marinas <catalin.marinas@....com>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 "David S. Miller" <davem@...emloft.net>,
 Dinh Nguyen <dinguyen@...nel.org>,
 Heiko Carstens <hca@...ux.ibm.com>,
 Helge Deller <deller@....de>,
 Huacai Chen <chenhuacai@...nel.org>,
 Kent Overstreet <kent.overstreet@...ux.dev>,
 Luis Chamberlain <mcgrof@...nel.org>,
 Michael Ellerman <mpe@...erman.id.au>,
 "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
 Palmer Dabbelt <palmer@...belt.com>,
 Puranjay Mohan <puranjay12@...il.com>,
 Rick P Edgecombe <rick.p.edgecombe@...el.com>,
 "Russell King (Oracle)" <linux@...linux.org.uk>,
 Steven Rostedt <rostedt@...dmis.org>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Thomas Gleixner <tglx@...utronix.de>,
 Will Deacon <will@...nel.org>,
 bpf <bpf@...r.kernel.org>,
 linux-arm-kernel@...ts.infradead.org,
 linux-mips@...r.kernel.org,
 linux-mm <linux-mm@...ck.org>,
 linux-modules@...r.kernel.org,
 linux-parisc@...r.kernel.org,
 linux-riscv@...ts.infradead.org,
 linux-s390 <linux-s390@...r.kernel.org>,
 linux-trace-kernel@...r.kernel.org,
 linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
 loongarch@...ts.linux.dev,
 netdev@...r.kernel.org,
 sparclinux@...r.kernel.org,
 the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [PATCH v2 02/12] mm: introduce execmem_text_alloc() and
 jit_text_alloc()

> On Jun 19, 2023, at 10:09 AM, Andy Lutomirski <luto@...nel.org> wrote:
> 
> But jit_text_alloc() can't do this, because the order of operations doesn't match.  With jit_text_alloc(), the executable mapping shows up before the text is populated, so there is no atomic change from not-there to populated-and-executable.  Which means that there is an opportunity for CPUs, speculatively or otherwise, to start filling various caches with intermediate states of the text, which means that various architectures (even x86!) may need serialization.
> 
> For eBPF- and module- like use cases, where JITting/code gen is quite coarse-grained, perhaps something vaguely like:
> 
> jit_text_alloc() -> returns a handle and an executable virtual address, but does *not* map it there
> jit_text_write() -> write to that handle
> jit_text_map() -> map it and synchronize if needed (no sync needed on x86, I think)

Andy, would you mind explaining why you think a sync is not needed? I mean I have a “feeling” that perhaps TSO can guarantee something based on the order of write and page-table update. Is that the argument?

On this regard, one thing that I clearly do not understand is why *today* it is ok for users of bpf_arch_text_copy() not to call text_poke_sync(). Am I missing something?